[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 12:25:52 PST 2019


dmgreen added a comment.

Thanks for working on this! I ran some tests and it's looking great (except for a couple of outliers).



================
Comment at: lib/Target/ARM/ARMBaseInstrInfo.cpp:5431
+  unsigned AddrMode = (MI->getDesc().TSFlags & ARMII::AddrModeMask);
+  int Idx = MI->findRegisterUseOperandIdx(ARM::SP) + 1;
+  int64_t Offset = 0;
----------------
What if we are actually storing sp? As in something like,
t2STRi8 $sp, $r7, 12, ...


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57054/new/

https://reviews.llvm.org/D57054





More information about the llvm-commits mailing list