[PATCH] D56473: Allow 'static' storage specifier on an out-of-line member function template declaration in MSVCCompat mode

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 10:14:57 PST 2019


rnk added a comment.

In D56473#1371539 <https://reviews.llvm.org/D56473#1371539>, @lebedev.ri wrote:

> I feel like pointing out that this review happened with no lists subscribed, so it is practically invalid.


Fair enough, but there were two appropriate reviewers who approved it. I think it was an honest, fairly common mistake. Unless you have objections, I don't see a need to revert and have more discussion.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56473/new/

https://reviews.llvm.org/D56473





More information about the llvm-commits mailing list