[PATCH] D57206: [ThinLTO] Add option to dump per-module summary dot graph

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked an inline comment as done.
tejohnson added inline comments.


================
Comment at: lib/Analysis/ModuleSummaryAnalysis.cpp:641
+  }
+
   return Index;
----------------
mehdi_amini wrote:
> It this something that can be pushed to the client? It does not necessarily seems to me that it belongs to a library method that builds the summary (unless maybe if you're seeing this as pure debugging)
Not easily pushed into client - e.g. 'opt' simply invokes the BitcodeWriterPass passing in the flag as to whether to emit the summary index, and that pass simply adds the ModuleSummaryIndex building analysis pass as required. Unless by client you mean the bitcode writer? Since this should just be for debugging (and testing), making it an option on the builder analysis pass seemed to make sense.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57206/new/

https://reviews.llvm.org/D57206