[PATCH] D57144: [SLPVectorizer] Get rid of IndexQueue array from vectorizeStores. NFCI.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 06:17:44 PST 2019


ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4749
 
+  auto FindConsecutiveAccess = [&] (int K, int Idx) {
+    if (!isConsecutiveAccess(Stores[K], Stores[Idx], *DL, *SE))
----------------
yrouban wrote:
> ABataev wrote:
> > 1. Use `auto &&`.
> > 2. Do not use default capture, better to use explicit capture list.
> any reference on why //auto &&'// differs?
It is just to be sure that we don't do copy here, but a move.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57144/new/

https://reviews.llvm.org/D57144





More information about the llvm-commits mailing list