[PATCH] D57217: llvm-objcopy: Add support for -g as an alias for --strip-debug

Douglas Yung via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jan 25 00:13:17 PST 2019


dyung marked an inline comment as done.
dyung added inline comments.


================
Comment at: test/tools/llvm-objcopy/ELF/strip-debug.test:10
+# RUN: llvm-objcopy -g %t %t2g
+# Verify that --strip-debug and -g produce the same output
+# RUN: cmp %t2 %t2g
----------------
rupprecht wrote:
> This test -- running cmp against -g and --strip-debug output -- is really all that's needed. Duplication in all the other tests is not providing any more coverage. I think it's safe to revert all the other test files and all other modifications in this file.
I agree. I'll remove the rest of the changes and update the diff.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57217/new/

https://reviews.llvm.org/D57217





More information about the llvm-commits mailing list