[PATCH] D57190: [MC] Teach the MachO object writer about N_FUNC_COLD

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 17:12:45 PST 2019


pcc added a comment.

Interesting, what's the advantage of this over doing something like creating a `__cold` section in the `__TEXT` segment?



================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:660
+  case MCSA_Cold:
+    // Assemblers currently do not support a .cold directive.
+    return false;
----------------
It should be possible to teach MC to parse this at least, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57190/new/

https://reviews.llvm.org/D57190





More information about the llvm-commits mailing list