[PATCH] D57183: [COFF, ARM64] Fix localaddress to handle stack realignment

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 24 16:18:17 PST 2019


mgrang added a comment.

In D57183#1370366 <https://reviews.llvm.org/D57183#1370366>, @efriedma wrote:

> If there's a call to localaddress in a function without funclets or VLAs, we should use sp, yes.  That should be rare in practice, but I guess the testcase is an example.


So I guess the logic should be something like this:

  if (!hasVarSizedObjects && !hasFunclets) --> use SP
  else if (needsStackRealignment) --> use BP
  else --> use FP


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57183/new/

https://reviews.llvm.org/D57183





More information about the llvm-commits mailing list