[PATCH] D57182: [MC] Remove unused inline function and stale comments; NFC

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: nemanjai, jasonliu.
Herald added subscribers: sunfish, aheejin, sbc100.

Take care of some missing clean-ups that belong with r249548 and some
other copy/paste that had happened. In particular, the destructors are
no longer vtable anchors after r249548; and `setSectionName` in
`MCSectionWasm` is private and unused since r313058 culled its only
caller.


Repository:
  rL LLVM

https://reviews.llvm.org/D57182

Files:
  include/llvm/MC/MCSectionWasm.h
  lib/MC/MCSectionCOFF.cpp
  lib/MC/MCSectionELF.cpp
  lib/MC/MCSectionWasm.cpp


Index: lib/MC/MCSectionWasm.cpp
===================================================================
--- lib/MC/MCSectionWasm.cpp
+++ lib/MC/MCSectionWasm.cpp
@@ -14,7 +14,7 @@
 
 using namespace llvm;
 
-MCSectionWasm::~MCSectionWasm() {} // anchor.
+MCSectionWasm::~MCSectionWasm() = default;
 
 // Decides whether a '.section' directive
 // should be printed before the section name.
Index: lib/MC/MCSectionELF.cpp
===================================================================
--- lib/MC/MCSectionELF.cpp
+++ lib/MC/MCSectionELF.cpp
@@ -17,7 +17,7 @@
 
 using namespace llvm;
 
-MCSectionELF::~MCSectionELF() = default; // anchor.
+MCSectionELF::~MCSectionELF() = default;
 
 // Decides whether a '.section' directive
 // should be printed before the section name.
Index: lib/MC/MCSectionCOFF.cpp
===================================================================
--- lib/MC/MCSectionCOFF.cpp
+++ lib/MC/MCSectionCOFF.cpp
@@ -14,7 +14,7 @@
 
 using namespace llvm;
 
-MCSectionCOFF::~MCSectionCOFF() = default; // anchor.
+MCSectionCOFF::~MCSectionCOFF() = default;
 
 // ShouldOmitSectionDirective - Decides whether a '.section' directive
 // should be printed before the section name
Index: include/llvm/MC/MCSectionWasm.h
===================================================================
--- include/llvm/MC/MCSectionWasm.h
+++ include/llvm/MC/MCSectionWasm.h
@@ -48,8 +48,6 @@
       : MCSection(SV_Wasm, K, Begin), SectionName(Section), UniqueID(UniqueID),
         Group(group) {}
 
-  void setSectionName(StringRef Name) { SectionName = Name; }
-
 public:
   ~MCSectionWasm();
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57182.183371.patch
Type: text/x-patch
Size: 1597 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190124/72e540ce/attachment.bin>