[PATCH] D57115: [llvm] Remove dependency on <algorithm> [NFC]

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 12:42:04 PST 2019


dblaikie added a comment.

"mainly" used for std::sort might be true, but "only" used might be harder to prove - did you use any tooling to test that these inclusions weren't needed other than "this code still compiles" (which has the problem that the inclusion might be used, but also included indirectly from some other header - so removing it may still compile, but introduces an undesirable indirect dependency on an implementation detail of some other header)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57115/new/

https://reviews.llvm.org/D57115





More information about the llvm-commits mailing list