[PATCH] D56624: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of `noreturn` calls

Roman Lebedev via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 23:05:17 PST 2019


Please revert this.
First, this wasn't reviewed.
Second, the lists weren't subscribed.

On Thu, Jan 24, 2019 at 4:08 AM Julian Lettner via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> This revision was not accepted when it landed; it landed in state "Needs Review".
> This revision was automatically updated to reflect the committed changes.
> Closed by commit rL352003: [Sanitizers] UBSan unreachable incompatible with ASan in the presence of… (authored by yln, committed by ).
> Herald added a subscriber: llvm-commits.
>
> Changed prior to commit:
>   https://reviews.llvm.org/D56624?vs=183200&id=183212#toc
>
> Repository:
>   rL LLVM
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D56624/new/
>
> https://reviews.llvm.org/D56624
>
> Files:
>   cfe/trunk/lib/CodeGen/CGCall.cpp
>   cfe/trunk/test/CodeGenCXX/ubsan-unreachable.cpp
>   compiler-rt/trunk/test/ubsan/TestCases/Misc/unreachable_asan-compatibility.c
>   llvm/trunk/docs/LangRef.rst
>   llvm/trunk/include/llvm/Bitcode/LLVMBitCodes.h
>   llvm/trunk/include/llvm/IR/Attributes.td
>   llvm/trunk/lib/AsmParser/LLLexer.cpp
>   llvm/trunk/lib/AsmParser/LLParser.cpp
>   llvm/trunk/lib/AsmParser/LLToken.h
>   llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
>   llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp
>   llvm/trunk/lib/IR/Attributes.cpp
>   llvm/trunk/lib/IR/Verifier.cpp
>   llvm/trunk/lib/Transforms/IPO/ForceFunctionAttrs.cpp
>   llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
>   llvm/trunk/lib/Transforms/Utils/CodeExtractor.cpp
>   llvm/trunk/test/Bitcode/attributes.ll
>   llvm/trunk/test/Instrumentation/AddressSanitizer/instrument-no-return.ll
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list