[PATCH] D57120: [ADT] Notify ilist traits about in-list transfers

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 14:59:16 PST 2019


rnk added a comment.

In D57120#1368541 <https://reviews.llvm.org/D57120#1368541>, @chandlerc wrote:

> I live in fear of the use cases we haven't yet thought of for this that we will discover in the future. ;] But proceed, LGTM!


Yeah, this is a pretty intimate specialization point for a data structure to have. But, it's not widely used outside of LLVM's core IR (and MIR) data structures.

> Maybe add a unittest exercising this so we don't break it accidentally and fail to notice? No need for another round of review there.

Done, thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57120/new/

https://reviews.llvm.org/D57120





More information about the llvm-commits mailing list