[PATCH] D57052: [IPCP] Don't crash due to arg count mismath between caller/callee

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 14:44:53 PST 2019


efriedma added inline comments.


================
Comment at: lib/Transforms/IPO/IPConstantPropagation.cpp:72
+    // count mismatches.
+    if (ACS.getNumArgOperands() != ArgumentConstants.size())
+      return false;
----------------
Checking the number of arguments probably isn't sufficient here; you also need to check the arguments have the same type.

(I'm not sure the check belongs here, as opposed to the AbstractCallSite constructor, but we can work that out later.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57052/new/

https://reviews.llvm.org/D57052





More information about the llvm-commits mailing list