[PATCH] D57117: GlobalISel: Add helper to LLT to get a scalar or vector

Volkan Keles via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 13:47:17 PST 2019


volkan added a comment.

Could you add a test to unittests/CodeGen/LowLevelTypeTest.cpp?



================
Comment at: include/llvm/Support/LowLevelTypeImpl.h:79
+    LLT ScalarTy = LLT::scalar(ScalarSize);
+    return NumElements == 1 ? ScalarTy : LLT::vector(NumElements, ScalarTy);
+  }
----------------
This can be replaced with:
```
return scalarOrVector(NumElements, LLT::scalar(ScalarSize));
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57117/new/

https://reviews.llvm.org/D57117





More information about the llvm-commits mailing list