[PATCH] D56329: Fix some warnings on MSVC

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 12:38:57 PST 2019


aganea marked an inline comment as done.
aganea added inline comments.


================
Comment at: unittests/Support/CMakeLists.txt:93
+if(MSVC)
+  if( CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.15 )
+    # Since VS2017 15.8, the following snippet: Failed<CustomSubError>()
----------------
@rnk: Regarding your last comment, please see my latest updated diff (lines 92-100 below). This fixes the warning. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56329/new/

https://reviews.llvm.org/D56329





More information about the llvm-commits mailing list