[PATCH] D56387: [DAGCombiner] Enable SimplifyDemandedBits vector support for TRUNCATE (WIP)

Huihui Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 12:00:24 PST 2019


huihuiz added inline comments.


================
Comment at: test/CodeGen/ARM/lowerMUL-newload.ll:28
 ; CHECK-NEXT:    bx lr
 entry:
 ; The test case trying to vectorize the pseudo code below.
----------------
RKSimon wrote:
> This just looks like we're missing something for the ARMISD::VMULL lowering
Using "CHECK-NEXT" and matching with the exact register names will make this test cast very sensitive to scheduling and register allocation changes.
Use pattern matching should be a better approach.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56387/new/

https://reviews.llvm.org/D56387





More information about the llvm-commits mailing list