[PATCH] D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 09:23:33 PST 2019


ruiu accepted this revision.
ruiu added a comment.

I don't think that there's an unwritten rule that a person from the same company cannot approve coworkers' patches, but anyways, I wonder where `--inlining` option came from. This is not a new option, but GNU addr2line doesn't seem to take the option. At least, in their manual, there's no description about `--inlining`; the tool only accepts `-i` and `--inlines`. Maybe we should remove `--inlining` from llvm-symbolizer if it is doable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57083/new/

https://reviews.llvm.org/D57083





More information about the llvm-commits mailing list