[PATCH] D53355: Introducing VPPHINode

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 06:53:08 PST 2019


rengolin added a comment.

In D53355#1366988 <https://reviews.llvm.org/D53355#1366988>, @npanchen wrote:

> Sorry for this long reply. As Satish has pointed out in his review <https://reviews.llvm.org/D53349>, this VPPHINode will be used to generate blending.


Right, that review has been approved. Once it lands, we should look into this patch and the one that will make use of it as a unit.

It can still remain as two separate patches, but by the looks of it, the next patch is not prepared to upstream yet, which means it can still have changes.

It would be good to see both patches, and with real tests on the second, to make sure the changes here are final.

thanks!
--renato


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53355/new/

https://reviews.llvm.org/D53355





More information about the llvm-commits mailing list