[PATCH] D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-symbolizer/sym.test:26
+RUN: llvm-symbolizer -inlines -print-address -pretty-print -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck -check-prefix="PRETTY" %s 
+RUN: llvm-symbolizer -inlines -print-address -p -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck -check-prefix="PRETTY" %s
+RUN: llvm-symbolizer -i -print-address -pretty-print -obj=%p/Inputs/addr.exe < %p/Inputs/addr.inp | FileCheck -check-prefix="PRETTY" %s 
----------------
Quolyk wrote:
> One more nit. This file contains redundant tests. coff-exports.test tests are already covered in coff-dwarf.test. On the one hand the more tests the better, on the other hand they test the same thing. @jhenderson is more confident, I suggest him to clarify this. Probably you have opinion on that.
I'm not too bothered by this either way. In an ideal world, we would actually have a test dedicated to --inlining and its aliases, rather than adding them here, but I don't know if there's a huge benefit to doing that. @dyung, if you're happy enough writing such a test, it might be worthwhile.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57083/new/

https://reviews.llvm.org/D57083