[PATCH] D57083: llvm-symbolizer: Add support for -i and -inlines as aliases for -inlining

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: test/tools/llvm-symbolizer/coff-dwarf.test:8
+RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
+RUN:     | llvm-symbolizer --i --relative-address -obj="%p/Inputs/coff-dwarf.exe" \
+RUN:     | FileCheck %s
----------------
I don't think we want to be testing `--i`. GNU addr2line's help text only lists `-i`.


================
Comment at: test/tools/llvm-symbolizer/coff-exports.test:8
+RUN: grep '^ADDR:' %s | sed -s 's/ADDR: //' \
+RUN: 	 | llvm-symbolizer --i --relative-address -obj="%p/Inputs/coff-exports.exe" \
+RUN:	 | FileCheck %s
----------------
Ditto.


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:58
+    ClPrintInliningAliasI("i", cl::desc("Alias for -inlining"),
+                          cl::NotHidden, cl::aliasopt(ClPrintInlining));
+static cl::alias
----------------
Please add cl::Grouping here and update the test in D57046 when that lands.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57083/new/

https://reviews.llvm.org/D57083