[PATCH] D57030: [CommandLine] Don't print empty sentinel values from EnumValN lists in help text

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 23 01:11:43 PST 2019


thopre added a comment.

In D57030#1367059 <https://reviews.llvm.org/D57030#1367059>, @ruiu wrote:

> Ideally I believe we should print out something like this for an option that takes an optional argument:
>
>   -mhvx                                            - Enable Hexagon Vector eXtensions
>   -mhvx=<value>                                    - Enable Hexagon Vector eXtensions
>      =v60                                           -   Build for HVX v60
>      =v62                                           -   Build for HVX v62
>      =v65                                           -   Build for HVX v65
>      =v66                                           -   Build for HVX v66
>   
>
> Do you think that's doable?


+1, that is much clearer. Perhaps even:

  -mhvx                                            - Enable Hexagon Vector eXtensions
  -mhvx='<value>'                            - Enable Hexagon Vector eXtensions
     ='v60'                                           -   Build for HVX v60
     ='v62'                                           -   Build for HVX v62
     ='v65'                                           -   Build for HVX v65
     ='v66'                                           -   Build for HVX v66

To be able to list ='' for sentinel value which are not ValueOptional.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57030/new/

https://reviews.llvm.org/D57030





More information about the llvm-commits mailing list