[PATCH] D56717: [SLH] AArch64: correctly pick temporary register to mask SP

Wed Jan 23 00:37:12 PST 2019

kristof.beyls marked 2 inline comments as done.
kristof.beyls added inline comments.

================
Comment at: llvm/lib/Target/AArch64/AArch64SpeculationHardening.cpp:307
+    // already to do this - but it's unclear if that could easily be used here.
+    unsigned TmpReg = RS.FindUnusedReg(&AArch64::GPR64allRegClass);
+    LLVM_DEBUG(dbgs() << "RS finds "
----------------
olista01 wrote:
> GPR64allRegClass includes SP and XZR, I don't think it actually matters here because neither of them are allocatable, but it would be clearer to use GPR64common.
Nice catch - thanks for noticing.
I've followed your suggestion in the committed code.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56717/new/

https://reviews.llvm.org/D56717