[PATCH] D40387: [X86][SSE]: Adding full coverage of MC encoding tests for the SSE isa sets.<NFC>

Wang Tianqing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 23:53:15 PST 2019


tianqing added a comment.

In D40387#1367366 <https://reviews.llvm.org/D40387#1367366>, @craig.topper wrote:

> Why were the SSE4a tests removed? They should be split out, but I don't see any reason to remove them unless we already have equivalent coverage for them.


I saw there is a x86_64-sse4a.s which has the 64-bit part already covered. Should I just ignore it and split out SSE4a-32/64.s, or just add the 32-bit tests with some name like x86-sse4a.s?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D40387/new/

https://reviews.llvm.org/D40387





More information about the llvm-commits mailing list