[PATCH] D56954: hwasan: Move memory access checks into small outlined functions on aarch64.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 17:16:14 PST 2019


pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64RegisterBankInfo.cpp:254
+  case AArch64::GPR64common_and_GPR64noipRegClassID:
+  case AArch64::GPR64noip_and_tcGPR64RegClassID:
   case AArch64::tcGPR64RegClassID:
----------------
eugenis wrote:
> These are weird. At least one of them goes away if GPR64noip is derived from GPR64common instead of GPR64.
> 
Yeah. There's a todo at the top of this file to make it be generated by tblgen, which certainly makes sense at least for this function.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56954/new/

https://reviews.llvm.org/D56954





More information about the llvm-commits mailing list