[PATCH] D56510: [libFuzzer][MSVC] Enable building libFuzzer with MSVC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 16:46:05 PST 2019


rnk added inline comments.


================
Comment at: compiler-rt/trunk/lib/fuzzer/CMakeLists.txt:77
+  # thread_local when it isn't even used on Windows.
+  list(APPEND LIBFUZZER_CFLAGS /EHsc)
+else()
----------------
Are you sure we want to enable exceptional destructor cleanups in libfuzzer targets? I don't think it will hurt, but what warnings are we hitting? Does libfuzzer actually use try/catch? If so, yes, this makes sense.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56510/new/

https://reviews.llvm.org/D56510





More information about the llvm-commits mailing list