[PATCH] D57016: [llvm-readelf] Stop suppressing static symbol output when --dyn-symbols is specified with --symbols

Tue Jan 22 16:02:17 PST 2019

rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

LGTM with just a question

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:3181
+    return;
   this->dumper()->printSymbolsHelper(true);
+  if (PrintSymbols)
----------------
IIUC, printSymbols(/*PrintSymbols=*/true, /*PrintDynamicSymbols=*/false) will still print dynamic symbols here, is that intentional? I think it is, based on the patch description of rL287786 -- if so, can you leave a comment somewhere, maybe also mention it in command line help string?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57016/new/

https://reviews.llvm.org/D57016