[PATCH] D57045: [llvm-objcopy] [COFF] Error out on use of unhandled options

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 15:48:45 PST 2019


rupprecht accepted this revision.
rupprecht added a comment.
This revision is now accepted and ready to land.

This doesn't seem like the best solution long-term, but probably makes testing llvm-objcopy on COFF much easier (expose missing functionality more loudly).

Maybe we could add something to the tablegen saying which object type each flag is supported for, and if that flag is set & we detect the input is not that object type, error?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57045/new/

https://reviews.llvm.org/D57045





More information about the llvm-commits mailing list