[PATCH] D56955: COFF, ELF: Adjust ICF hash computation to account for self relocations.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 15:10:05 PST 2019


pcc added a comment.

In D56955#1366983 <https://reviews.llvm.org/D56955#1366983>, @ruiu wrote:

> Or maybe we can simply add hashes instead of xor'ing?


Yeah, that could work too. Although my first thought was that combining hashes that way could end up losing entropy, it doesn't seem like we'd be losing too much in practice because if you have (say) 31 self relocations you would only end up losing 5 bits of entropy,. I'll do an experiment to see how well that works.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56955/new/

https://reviews.llvm.org/D56955





More information about the llvm-commits mailing list