[PATCH] D57061: [X86] Support 'offset' when parsing intel syntax through llvm-mc or gcc inline assembly

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 11:47:43 PST 2019


rnk added a comment.

> This patch adds support outside of the first pass of MS inline assembly. I left the first pass MS inline assembly code alone for now and added a fixme. I'm not sure if its correct or not. It looks to delete the 'offset' keyword as part of its rewrite, but that seems wrong.

I think you're right, we probably don't need the rewrite if MC can just parse it directly after this change. I think it's fine to leave the rewrite for now, but we should remove it if we can in a followup.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57061/new/

https://reviews.llvm.org/D57061





More information about the llvm-commits mailing list