[PATCH] D57005: [LLD] [docs] Amend the release notes with more things I've contributed since the last release

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 10:53:51 PST 2019


ruiu added inline comments.


================
Comment at: docs/ReleaseNotes.rst:73
+* Actually generate a codeview build id signature, even if not creating a PDB.
+  Previously, the ``--build-id`` option was accepted and ignored, but no
+  build id was generated.
----------------
mstorsjo wrote:
> ruiu wrote:
> > I don't know if I get the meaning of this sentence correctly. The option is accepted and ignored, /therefore/ no build id was generated?
> Well, we still ignore it in the mingw frontend and generate the buildid in COFF/Writer.cpp regardless if the flag was set.
How about something like this? Previously, the build-id option did not actually generate a build id unless --pdb was specified.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57005/new/

https://reviews.llvm.org/D57005





More information about the llvm-commits mailing list