[PATCH] D56835: GlobalISel: Make buildConstant handle vectors

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 09:42:22 PST 2019


arsenm marked an inline comment as done.
arsenm added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/MachineIRBuilder.cpp:262
+
+    auto MIB = buildInstr(TargetOpcode::G_BUILD_VECTOR);
+    Res.addDefToMIB(*getMRI(), MIB);
----------------
aditya_nandakumar wrote:
> Any reason for not using buildBuildVector here?
It seemed less convenient to create the vector of arguments than to just add them directly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56835/new/

https://reviews.llvm.org/D56835





More information about the llvm-commits mailing list