[PATCH] D54742: [CodeMetrics] Don't let extends of i1 be free.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 05:55:21 PST 2019


jonpa added a comment.

ping!



================
Comment at: include/llvm/Analysis/TargetTransformInfoImpl.h:813
+      // has been removed. A target that needs it should override this
+      // method.
+      return static_cast<T *>(this)->getExtCost(cast<Instruction>(U),
----------------
lebedev.ri wrote:
> 'this' method? `getGEPCost()` or `getExtCost()` ?
I was thinking about the same function as is changed here - getUserCost(). Comment updated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54742/new/

https://reviews.llvm.org/D54742





More information about the llvm-commits mailing list