[llvm] r351816 - Fix "comparison of unsigned expression >= 0 is always true" warning. NFCI.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 05:18:26 PST 2019


Author: rksimon
Date: Tue Jan 22 05:18:26 2019
New Revision: 351816

URL: http://llvm.org/viewvc/llvm-project?rev=351816&view=rev
Log:
Fix "comparison of unsigned expression >= 0 is always true" warning. NFCI.

Modified:
    llvm/trunk/lib/Target/X86/X86InstrInfo.cpp

Modified: llvm/trunk/lib/Target/X86/X86InstrInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrInfo.cpp?rev=351816&r1=351815&r2=351816&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86InstrInfo.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86InstrInfo.cpp Tue Jan 22 05:18:26 2019
@@ -1582,7 +1582,7 @@ MachineInstr *X86InstrInfo::commuteInstr
     if (DstIdx == SrcIdx && (ZMask & (1 << DstIdx)) == 0 &&
         countPopulation(ZMask) == 2) {
       unsigned AltIdx = findFirstSet((ZMask | (1 << DstIdx)) ^ 15);
-      assert(0 <= AltIdx && AltIdx < 4 && "Illegal insertion index");
+      assert(AltIdx < 4 && "Illegal insertion index");
       unsigned AltImm = (AltIdx << 6) | (AltIdx << 4) | ZMask;
       auto &WorkingMI = cloneIfNew(MI);
       WorkingMI.getOperand(MI.getNumOperands() - 1).setImm(AltImm);




More information about the llvm-commits mailing list