[PATCH] D57035: Add missing include (cstdlib) to Demangle.h

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 22 01:28:52 PST 2019


jhenderson added a comment.

LGTM, if it is moved into Demangle.cpp. I don't think we want to be adding unnecessary dependencies to headers, when a .cpp file change would suffice.



================
Comment at: include/llvm/Demangle/Demangle.h:13
 #include <cstddef>
+#include <cstdlib>
 #include <string>
----------------
Shouldn't this be in Demangle.cpp, since the only usage is there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57035/new/

https://reviews.llvm.org/D57035





More information about the llvm-commits mailing list