[PATCH] D57016: [llvm-readelf] Stop suppressing static symbol output when --dyn-symbols is specified with --symbols

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 19:50:03 PST 2019


sbc100 added inline comments.


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:1397
+    printDynamicSymbols();
+}
+
----------------
Why not keep this as the default implementation rather than duplicating it 3 times?  Of the 4 object formats it looks like only ELF needs different behaviour.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57016/new/

https://reviews.llvm.org/D57016





More information about the llvm-commits mailing list