[PATCH] D57027: [AMDGPU] Factored PAL metadata handling out into its own class

Tim Renouf via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 09:47:35 PST 2019


tpr created this revision.
Herald added subscribers: llvm-commits, kristina, rupprecht, t-tye, dstuttard, yaxunl, mgorny, nhaehnle, wdng, jvesely, kzhuravl, arsenm.
tpr added reviewers: scott.linder, kzhuravl.

This commit introduces a new AMDGPUPALMetadata class that:

- is inside the AMDGPU target;
- keeps an in-memory representation of PAL metadata;
- provides a method for use by LLPC to write metadata into LLVM IR;
- provides a method to read the frontend-supplied metadata from LLVM IR;
- provides methods for the asm printer to set metadata items;
- provides methods to write the metadata as a binary blob to put in a .note record or as an asm directive;
- provides a method to read the metadata as a binary blob from a .note record.

Because llvm-readobj cannot call directly into a target, I had to remove
llvm-readobj's ability to dump PAL metadata, pending a resolution to
https://reviews.llvm.org/D52821

Change-Id: I756dc830894fcb6850324cdcfa87c0120eb2cf64


Repository:
  rL LLVM

https://reviews.llvm.org/D57027

Files:
  include/llvm/Support/AMDGPUMetadata.h
  lib/Support/AMDGPUMetadata.cpp
  lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
  lib/Target/AMDGPU/AMDGPUAsmPrinter.h
  lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp
  lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
  lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.cpp
  lib/Target/AMDGPU/Utils/AMDGPUPALMetadata.h
  lib/Target/AMDGPU/Utils/CMakeLists.txt
  test/CodeGen/AMDGPU/elf-notes.ll
  tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D57027.182808.patch
Type: text/x-patch
Size: 30454 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190121/f47c3b16/attachment.bin>


More information about the llvm-commits mailing list