[PATCH] D57014: [llvm-objcopy] Consistently use createStringError instead of make_error<StringError>. NFC.

Mon Jan 21 05:38:46 PST 2019

jhenderson added a comment.

In D57014#1365220 <https://reviews.llvm.org/D57014#1365220>, @mstorsjo wrote:

> In D57014#1365204 <https://reviews.llvm.org/D57014#1365204>, @jhenderson wrote:
>
> >
>
>
> Correct, the two cases where I add quotes but there's no test change for are currently not possible to trigger, I think - both the input as set by Reader, and updates by Object currently should make them impossible to trigger. I guess asserts would be an option then as well. (At an earlier point in the evolution of the removeSections patch, some of them were triggerable, but I realized it's easy to do the right thing instead of erroring out on dangling associative sections). There's also lots of error messages in Reader that aren't tested, mainly for broken inputs.

Okay, it might be nice to turn the unreachable ones into asserts (or simply delete the code), but that's not relevant to this change.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57014/new/

https://reviews.llvm.org/D57014