[PATCH] D57014: [llvm-objcopy] Consistently use createStringError instead of make_error<StringError>. NFC.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 05:18:39 PST 2019


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Make sure to mention in the commit comment that this also quotes certain symbol names.

I'm surprised that several of the error messages appear to be untested (only one test needed updating, but there are at least 3 different behaviour changes here). I take it testing them is not straightforward?

LGTM anyway.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57014/new/

https://reviews.llvm.org/D57014





More information about the llvm-commits mailing list