[PATCH] D56987: [Intrinsic] Expand vector SMULFIX to MUL on zero scale

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 02:52:40 PST 2019


RKSimon added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:5397
     Hi = DAG.getNode(ISD::MULHS, dl, VT, LHS, RHS);
   } else {
     report_fatal_error("Unable to expand signed fixed point multiplication.");
----------------
Why not let vectors try to use these cases and add a bail out?
```
} else if (VT.isVector()) {
  // Only expand vector types if we have the appropriate vector operations.
  return SDValue();
} else {
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56987/new/

https://reviews.llvm.org/D56987





More information about the llvm-commits mailing list