[PATCH] D56910: [llvm-readelf]Revert --dyn-symbols behaviour to make it GNU compatible, and add new --hash-symbols switch for old behaviour

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 21 01:41:31 PST 2019


jhenderson marked an inline comment as done.
jhenderson added inline comments.


================
Comment at: test/tools/llvm-readobj/gnu-symbols.test:3
+RUN:  -elf-output-style=GNU | FileCheck %s -check-prefix ELF32
+RUN: llvm-readobj -symbols %p/Inputs/relocs.obj.elf-x86_64 -elf-output-style=GNU \
 RUN:   | FileCheck %s -check-prefix ELF64
----------------
grimar wrote:
> nit: seems you changed `--elf-output-style` to `-elf-output-style`. That made more lines to be shown
> as changes for probably no solid reason? I would commit such changes as NFC separately if you want them.
It's mostly just to make things consistent. I'll commit separately.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56910/new/

https://reviews.llvm.org/D56910





More information about the llvm-commits mailing list