[PATCH] D35989: [SCEV][NFC] Introduces expression sizes estimation

Sun Jan 20 22:04:04 PST 2019

mkazantsev added a comment.

In D35989#1360151 <https://reviews.llvm.org/D35989#1360151>, @sanjoy wrote:

> In D35989#901470 <https://reviews.llvm.org/D35989#901470>, @mkazantsev wrote:
>
> > Re-requesting review per Daniil's comment above. @sanjoy , is this overhead acceptable? I can come up with an alternative maps-based solution if it is not (i.e. only calculate this size for those SCEVs where we need it).
>
>
> Do you have an estimate of what is the max memory consumption when bootstrapping?  I'm pretty sure 0.8M is a very small fraction of the total memory consumption, but would be nice to be sure.

We were estimating max amount of SCEVs that exist at the same time during a bootstrap compilation, and then multiplied by field size of 32 bits (now it's 16 bits). So yes, it's basically a small fraction of this memory.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D35989/new/

https://reviews.llvm.org/D35989