[PATCH] D56949: FileOutputBuffer: handle mmap(2) failure

Fri Jan 18 17:19:57 PST 2019

sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Nice!

When I was thinking about doing this I also had a hard time envisioning how to test (Presumably it would require some kind of mock for fs::mapped_file_region).

I wonder if there are other places where this fallback is already performed at a higher level that we could presumably now remove some code?  It seems like other tools such as clang were already handling the lack of mmap since the bug reporter didn't hit an issue until link time.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56949/new/

https://reviews.llvm.org/D56949