[PATCH] D53765: [RFC prototype] Implementation of asm-goto support in LLVM

Fri Jan 18 14:46:46 PST 2019

nickdesaulniers added a comment.

> Hopefully fix https://github.com/ClangBuiltLinux/linux/issues/320#issuecomment-455435791. Had to exclude CallBr predecessors in JumpThreading.

Yes looks good; I've closed that issue as unreproducible.

For https://github.com/ClangBuiltLinux/linux/issues/317, I think we're hitting https://bugs.llvm.org/show_bug.cgi?id=39560.  Reproducer https://gist.github.com/nickdesaulniers/a69b44159f4d42a34fc1b5d18cb7b608.  If we fix that, then I should be able to drop my out of tree kernel patch.

Finally, https://github.com/ClangBuiltLinux/linux/issues/319 looks troubling, but I haven't really dug into it.  It *may* be due to my out of tree kernel patch (https://github.com/ClangBuiltLinux/linux/commit/0670525ded48caf958b6535d388e6478b6b14a4b), but if we can support inlining then it looks like my out of tree patch should not be necessary: https://godbolt.org/z/exFrxS.  Otherwise, it may be another codegen bug due to this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53765/new/

https://reviews.llvm.org/D53765