[PATCH] D55585: RFC: [LLD][COFF] Parallel GHASH generation at link-time

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

I thought this was demo code, but I was confused by rnk's comment about the hash flag below, so replying to that.



================
Comment at: lld/trunk/COFF/Driver.cpp:608-613
+  if (ArgL == "md5")
+    Hasher = codeview::GloballyHashedType::HashType::MD5;
+  else if (ArgL == "sha1")
+    Hasher = codeview::GloballyHashedType::HashType::SHA1;
+  else if (ArgL == "cityhash")
+    Hasher = codeview::GloballyHashedType::HashType::CityHash;
----------------
rnk wrote:
> ruiu wrote:
> > What is the point of making it selectable to users? It feels to me that you should pick up the one that you think the best and just use it.
> I think it's important to at least have the flexibility for developers to test different hashing schemes. We don't have to document all these flags. Users don't have to know about them, and we can remove them later.
Having this while working on this patch makes sense, but the experiment show that xhash is fast enough, so we wouldn't want to check this flag in, right? (And an implementation of e.g. cityhash just for this flag even though cityhash doesn't have any advantages over hashes using code we already have in tree.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55585/new/

https://reviews.llvm.org/D55585