[PATCH] D56908: gn build: Stop passing -DLLVM_LIBXML2_ENABLED to some targets

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added reviewers: phosek, pcc.

This is a remnant from before the gn build had a working config.h.

Defining LLVM_LIBXML2_ENABLED only for targets that depend on build/libs/xml is nice in that only some of the codebase needs to be rebuilt when llvm_enable_libxml2 changes -- but config.h already defines it and defining it there and then redundantly a second time for some targets is worse than having it just in config.h.

No behavior change.


https://reviews.llvm.org/D56908

Files:
  llvm/utils/gn/build/libs/xml/BUILD.gn


Index: llvm/utils/gn/build/libs/xml/BUILD.gn
===================================================================
--- llvm/utils/gn/build/libs/xml/BUILD.gn
+++ llvm/utils/gn/build/libs/xml/BUILD.gn
@@ -3,7 +3,6 @@
 
 config("xml_config") {
   visibility = [ ":xml" ]
-  defines = [ "LLVM_LIBXML2_ENABLED" ]
   libs = [ "xml2" ]
   if (host_os == "mac") {
     include_dirs = [ "$mac_sdk_path/usr/include/libxml2" ]


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56908.182515.patch
Type: text/x-patch
Size: 414 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190118/bf9e9fba/attachment.bin>