[PATCH] D56773: [llvm-symbolizer] Add -no-demangle as alias for -demangle=false

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:210
+  // If both --demangle and --no-demangle are specified then pick
+  // the last one as demangle option.
+  if (ClNoDemangle.getPosition() > ClDemangle.getPosition())
----------------
Nit: remove the "as demangle option".

Also, use clang-format to choose when to split the column onto multiple lines, rather than doing it by hand. I think most (maybe all) of this line will fit on the same line as the first line.


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:212
+  if (ClNoDemangle.getPosition() > ClDemangle.getPosition())
+    ClDemangle = !ClNoDemangle;
+
----------------
What does `getPosition` do if the option is not on the command-line?


================
Comment at: tools/llvm-symbolizer/llvm-symbolizer.cpp:214-216
+  LLVMSymbolizer::Options Opts(ClPrintFunctions, ClUseSymbolTable,
+                               ClDemangle, ClUseRelativeAddress,
+                               ClDefaultArch);
----------------
Why has this changed?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56773/new/

https://reviews.llvm.org/D56773