[llvm] r351477 - Fix an MSVC bot failure from r351474.

Erik Pilkington via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 14:43:29 PST 2019


Yeah, good point. Looks like this has been in this file since it's 
creation, so I don't think its a problem in practice, but I'll add it in 
anyways. r351493.

Thanks!

On 1/17/19 2:31 PM, Reid Kleckner wrote:
> To be truly pedantic, there should be an #else that defines this macro 
> to nothing.
>
> On Thu, Jan 17, 2019 at 12:56 PM Erik Pilkington via llvm-commits 
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>
>     Author: epilk
>     Date: Thu Jan 17 12:52:10 2019
>     New Revision: 351477
>
>     URL: http://llvm.org/viewvc/llvm-project?rev=351477&view=rev
>     Log:
>     Fix an MSVC bot failure from r351474.
>
>     Modified:
>         llvm/trunk/include/llvm/Demangle/DemangleConfig.h
>
>     Modified: llvm/trunk/include/llvm/Demangle/DemangleConfig.h
>     URL:
>     http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Demangle/DemangleConfig.h?rev=351477&r1=351476&r2=351477&view=diff
>     ==============================================================================
>     --- llvm/trunk/include/llvm/Demangle/DemangleConfig.h (original)
>     +++ llvm/trunk/include/llvm/Demangle/DemangleConfig.h Thu Jan 17
>     12:52:10 2019
>     @@ -61,7 +61,7 @@
>      #if __has_builtin(__builtin_unreachable) ||
>     DEMANGLE_GNUC_PREREQ(4, 5, 0)
>      #define DEMANGLE_UNREACHABLE __builtin_unreachable()
>      #elif defined(_MSC_VER)
>     -#define DEMANGLE_BUILTIN_UNREACHABLE __assume(false)
>     +#define DEMANGLE_UNREACHABLE __assume(false)
>      #endif
>
>      #if __has_attribute(noinline) || DEMANGLE_GNUC_PREREQ(3, 4, 0)
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190117/4e92580d/attachment.html>


More information about the llvm-commits mailing list