[PATCH] D56719: [DAGCombine] Enable more pre-indexed stores

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 14:21:51 PST 2019


efriedma added a comment.

In D56719#1362292 <https://reviews.llvm.org/D56719#1362292>, @efriedma wrote:

> > I just did a very brief experiment, and just checking if (Val == BasePtr || Val == Ptr || Ptr->isPredecessorOf(Val.getNode())) seems to do the right thing without any additional checks.
>
> Err, nevermind, that doesn't do anything; please ignore.


Hmm... actually, I'm just confusing myself.  My suggestion appears to fix your pre_inc_str_multi without causing any regressions (although I haven't run anything outside the regression tests).  I'm assuming that's the primary case you're interested in?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56719/new/

https://reviews.llvm.org/D56719





More information about the llvm-commits mailing list