[PATCH] D56855: Add ___Z demangling to new common demangle function

Erik Pilkington via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 13:44:28 PST 2019


erik.pilkington added inline comments.


================
Comment at: lib/Demangle/Demangle.cpp:18-19
   char *Demangled;
-  if (MangledName.compare(0, 2, "_Z") == 0)
+  if (MangledName.compare(0, 2, "_Z") == 0 ||
+      MangledName.compare(0, 4, "___Z") == 0)
     Demangled = itaniumDemangle(MangledName.c_str(), nullptr, nullptr, nullptr);
----------------
As of r351481, we allow leading underscores on these. Maybe it would be easier to flip this around so we call microsoftDemangle if the name starts with `?`, then itaniumDemangle otherwise?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56855/new/

https://reviews.llvm.org/D56855





More information about the llvm-commits mailing list