[PATCH] D56848: [LCSSA] Skip blocks in sub-loops when scanning for uses.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 12:40:16 PST 2019


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/LCSSA.cpp:328
   for (BasicBlock *BB : BlocksDominatingExits) {
+    // Skip blocks that are part of any sub-loops, as we already scanned them
+    // previously.
----------------
The relevant property here is that the sub-loops are already in LCSSA form, right?  The documentation for formLCSSA doesn't actually say that explicitly... granted, it's probably true in the cases we care about.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56848/new/

https://reviews.llvm.org/D56848





More information about the llvm-commits mailing list