[PATCH] D56853: [llvm-objdump] - Show aliases in -help.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 17 10:16:59 PST 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

I think this is a good change, and I agree with you that we don't need to test each alias.

Speaking of the `--help` message, I found there are other weird stuff there.  The options in the `--help` message are categorized as "Color Options", "General options" and "Generic Options". There is only one option under the "Color Options" category, which is `--color`. Most options are under "General Options". `--help` and `--version` are under "Generic Options". Frankly, these categories doesn't make sense at all to me. (what's the difference between "Generic" and "General"?)

Maybe we should remove the categories and display all options just asciibetically.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56853/new/

https://reviews.llvm.org/D56853





More information about the llvm-commits mailing list